feat: update lab 2 to nx 19.7 #37
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 9ae3089. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
docs/assets/lab2_cmds.svg
Outdated
There was a problem hiding this comment.
Added inkscape SVG in case we need to tweak this in the future
| /** | ||
| * TODO: figure out what best approach for getProjects(tree) is | ||
| * | ||
| * Right now, if you call the removeGenerator for a project and then | ||
| * immediately call getProjects(tree), getProjects will throw. | ||
| * | ||
| * This is due to getProjects fetching a list of project.json files | ||
| * using globWithWorkspaceContextSync, which globs against the real | ||
| * filesystem rather than the in-memory tree. | ||
| * | ||
| * Once the list of project.json flies is fetched, the project details | ||
| * are they attempted to be fetched from the in-memory tree, which | ||
| * subsequently fails because we just deleted it. | ||
| * | ||
| * See: {@link https://github.com/nrwl/nx/blob/master/packages/nx/src/generators/utils/project-configuration.ts#L251} | ||
| * | ||
| * Re-enabling this test will recreate the issue as long as the current | ||
| * workspace has at least one project in it (which the previous test will create) | ||
| */ |
There was a problem hiding this comment.
I've reached out to @FrozenPandaz about this and will address it in a future update once we figure out what to do with getProjects(tree).
For now, we just need to run the "reset workspace" migration separately from all the rest.
| { | ||
| "input": "./examples", | ||
| "glob": "**/*", | ||
| "output": "./examples" | ||
| } |
There was a problem hiding this comment.
This ensures the example files available for use in generators and migrations allow us to remove the duplicate code currently inlined into the migrations.
| for (const [projectName] of getProjects(tree)) { | ||
| await removeGenerator(tree, { | ||
| projectName, | ||
| skipFormat: true, | ||
| forceRemove: true, | ||
| }); | ||
| } |
There was a problem hiding this comment.
Since we pass forceRemove, we don't need to enumerate the projects and delete them in a specific order.
| @@ -33,166 +27,10 @@ export default async function update(tree: Tree) { | |||
| style: 'scss', | |||
| unitTestRunner: 'jest', | |||
| routing: true, | |||
| addPlugin: true, | |||
There was a problem hiding this comment.
Ensures we use crystallized config which is what the user will see when they run the commands directly.
19.7.2to19.7.4lab-examplesgenerator to copy files into placenx addto install react pluginlab-examplesgenerator rather than manually copying files over